From 0f5a1725a00b3efbf90c462c691a298ea9ff5f94 Mon Sep 17 00:00:00 2001 From: Thiago Macieira Date: Tue, 9 Nov 2021 08:31:50 -0800 Subject: [PATCH] QFactoryLoader: remove check-before-use of a directory Unnecessary. We can't read a directory's entries if it doesn't exist or isn't a directory. Change-Id: I5e52dc5b093c43a3b678fffd16b5edce70eb651e Reviewed-by: Qt CI Bot Reviewed-by: Marc Mutz --- src/corelib/plugin/qfactoryloader.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/corelib/plugin/qfactoryloader.cpp b/src/corelib/plugin/qfactoryloader.cpp index 64e0361826..bb1ebb8b20 100644 --- a/src/corelib/plugin/qfactoryloader.cpp +++ b/src/corelib/plugin/qfactoryloader.cpp @@ -170,9 +170,6 @@ inline void QFactoryLoaderPrivate::updateSinglePath(const QString &path) qCDebug(lcFactoryLoader) << "checking directory path" << path << "..."; - if (!QDir(path).exists(QLatin1String("."))) - return; - QStringList plugins = QDir(path).entryList( #if defined(Q_OS_WIN) QStringList(QStringLiteral("*.dll")),