QMetaTypeModuleHelper: suppress cppcoreguidelines-virtual-class-destructor
Says clang-tidy:
destructor of '(unnamed struct at qmetatype.cpp:966:14)' is public and non-virtual
in file:src/corelib/kernel/qmetatype.cpp line:966 col:14
static const struct : QMetaTypeModuleHelper
Yes, these classes are polymorphic (because the base class is). Yes,
the destructor is non-virtual (because the base class' one isn't, but
it's also protected, so fine).
But these classes are not used as base classes, so suppress the
warning.
Pick-to: 6.7 6.6 6.5 6.2
Change-Id: I75be86bca36a4a0e93d72acb1a0d2fe0dca1c505
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
bb10
parent
54824e7d2b
commit
11d153ae1c
|
|
@ -963,6 +963,7 @@ static const struct { const char * typeName; int typeNameLength; int type; } typ
|
|||
{nullptr, 0, QMetaType::UnknownType}
|
||||
};
|
||||
|
||||
// NOLINTNEXTLINE(cppcoreguidelines-virtual-class-destructor): this is not a base class
|
||||
static const struct : QMetaTypeModuleHelper
|
||||
{
|
||||
template<typename T, typename LiteralWrapper =
|
||||
|
|
|
|||
|
|
@ -56,6 +56,7 @@ QT_BEGIN_NAMESPACE
|
|||
|
||||
namespace {
|
||||
|
||||
// NOLINTNEXTLINE(cppcoreguidelines-virtual-class-destructor): this is not a base class
|
||||
static const struct : QMetaTypeModuleHelper
|
||||
{
|
||||
#define QT_IMPL_METATYPEINTERFACE_GUI_TYPES(MetaTypeName, MetaTypeId, RealName) \
|
||||
|
|
|
|||
|
|
@ -12,6 +12,7 @@ QT_BEGIN_NAMESPACE
|
|||
|
||||
namespace {
|
||||
|
||||
// NOLINTNEXTLINE(cppcoreguidelines-virtual-class-destructor): this is not a base class
|
||||
static const struct : QMetaTypeModuleHelper
|
||||
{
|
||||
const QtPrivate::QMetaTypeInterface *interfaceForType(int type) const override {
|
||||
|
|
|
|||
Loading…
Reference in New Issue