diff --git a/src/corelib/tools/qdatetime.cpp b/src/corelib/tools/qdatetime.cpp index ca398170a3..021053fc6d 100644 --- a/src/corelib/tools/qdatetime.cpp +++ b/src/corelib/tools/qdatetime.cpp @@ -1803,6 +1803,10 @@ QTime QTime::fromString(const QString& s, Qt::DateFormat f) const int minute(s.mid(3, 2).toInt(&ok)); if (!ok) return QTime(); + if (f == Qt::ISODate && s.size() == 5) { + // Do not need to specify seconds if using ISO format. + return QTime(hour, minute, 0, 0); + } const int second(s.mid(6, 2).toInt(&ok)); if (!ok) return QTime(); diff --git a/tests/auto/corelib/tools/qdatetime/tst_qdatetime.cpp b/tests/auto/corelib/tools/qdatetime/tst_qdatetime.cpp index e4cdb1a5c8..49fada6c0b 100644 --- a/tests/auto/corelib/tools/qdatetime/tst_qdatetime.cpp +++ b/tests/auto/corelib/tools/qdatetime/tst_qdatetime.cpp @@ -115,6 +115,8 @@ private slots: void dateFromStringFormat(); void timeFromStringFormat_data(); void timeFromStringFormat(); + void timeFromStringDateFormat_data(); + void timeFromStringDateFormat(); void dateTimeFromStringFormat_data(); void dateTimeFromStringFormat(); @@ -1435,6 +1437,32 @@ void tst_QDateTime::timeFromStringFormat() QCOMPARE(dt, expected); } +void tst_QDateTime::timeFromStringDateFormat_data() +{ + QTest::addColumn("string"); + QTest::addColumn("format"); + QTest::addColumn("expected"); + + QTest::newRow("valid, start of day, omit seconds") << QString::fromLatin1("00:00") << Qt::ISODate << QTime(0, 0, 0); + QTest::newRow("valid, omit seconds") << QString::fromLatin1("22:21") << Qt::ISODate << QTime(22, 21, 0); + QTest::newRow("valid, omit seconds (2)") << QString::fromLatin1("23:59") << Qt::ISODate << QTime(23, 59, 0); + QTest::newRow("valid, end of day") << QString::fromLatin1("23:59:59") << Qt::ISODate << QTime(23, 59, 59); + + QTest::newRow("invalid, empty string") << QString::fromLatin1("") << Qt::ISODate << invalidTime(); + QTest::newRow("invalid, too many hours") << QString::fromLatin1("25:00") << Qt::ISODate << invalidTime(); + QTest::newRow("invalid, too many minutes") << QString::fromLatin1("10:70") << Qt::ISODate << invalidTime(); + QTest::newRow("invalid, too many seconds") << QString::fromLatin1("23:59:60") << Qt::ISODate << invalidTime(); +} + +void tst_QDateTime::timeFromStringDateFormat() +{ + QFETCH(QString, string); + QFETCH(Qt::DateFormat, format); + QFETCH(QTime, expected); + + QTime dt = QTime::fromString(string, format); + QCOMPARE(dt, expected); +} void tst_QDateTime::dateTimeFromStringFormat_data() {