From 173ce3ab93ea1ff40cd68b6fad46f59773a177ca Mon Sep 17 00:00:00 2001 From: Giuseppe D'Angelo Date: Fri, 13 Sep 2013 12:40:24 +0200 Subject: [PATCH] Fix Strict Weak Ordering in qdoc's comparator MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit If both n1 and n2 are "Private", the comment says they're equivalent, but the function is actually stating that n1 < n2 AND n2 < n1. Change-Id: I8e30b32c1e5240551ab1808baf6fc476841dfde4 Reviewed-by: Martin Smith Reviewed-by: Topi Reiniƶ --- src/tools/qdoc/qdocindexfiles.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tools/qdoc/qdocindexfiles.cpp b/src/tools/qdoc/qdocindexfiles.cpp index cb387a9452..21731f921b 100644 --- a/src/tools/qdoc/qdocindexfiles.cpp +++ b/src/tools/qdoc/qdocindexfiles.cpp @@ -1135,7 +1135,7 @@ bool compareNodes(const Node* n1, const Node* n2) // Private nodes can occur in any order since they won't normally be // written to the index. if (n1->access() == Node::Private && n2->access() == Node::Private) - return true; + return false; if (n1->location().filePath() < n2->location().filePath()) return true;