From 23189a906882c79880cab5359b1ab74ba916223f Mon Sep 17 00:00:00 2001 From: Alessandro Portale Date: Wed, 26 Aug 2020 19:34:25 +0200 Subject: [PATCH] Fix warning: 'open' has superfluous mode bits; missing O_CREAT? Adding mode flags doesn't make sense if you don't create a file but only open if for reading. Change-Id: I9307b07cbbcddea565fff9258de7f7beb373a8ad Reviewed-by: Alexandru Croitor --- src/corelib/io/qresource.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/corelib/io/qresource.cpp b/src/corelib/io/qresource.cpp index 3aeaa1427b..80247de9a0 100644 --- a/src/corelib/io/qresource.cpp +++ b/src/corelib/io/qresource.cpp @@ -1173,7 +1173,7 @@ bool QDynamicFileResourceRoot::registerSelf(const QString &f) qsizetype data_len = 0; #if defined(QT_USE_MMAP) - int fd = QT_OPEN(QFile::encodeName(f), O_RDONLY, 0666); + int fd = QT_OPEN(QFile::encodeName(f), O_RDONLY); if (fd >= 0) { QT_STATBUF st; if (!QT_FSTAT(fd, &st) && st.st_size <= std::numeric_limits::max()) {