From 2b8e1a706e631e1a2e29f016823b11666d7f1f80 Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Mon, 2 Oct 2023 07:00:56 +0200 Subject: [PATCH] QPointer: mark converting assignment operators noexcept All operations they perform (copy/move construction + swap()) are noexcept, so these functions should be noexcept, too. Amends 93019dc0dee3dd3d568775250e3fae8eda072850 and (FIXME)93019dc0dee3dd3d568775250e3fae8eda072850(ONCE MERGED). Change-Id: I9010f87f93ce3efcefd8b28d848a3eadd6e74542 Reviewed-by: Thiago Macieira --- src/corelib/kernel/qpointer.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/corelib/kernel/qpointer.h b/src/corelib/kernel/qpointer.h index a279576493..2da21d7dd2 100644 --- a/src/corelib/kernel/qpointer.h +++ b/src/corelib/kernel/qpointer.h @@ -44,14 +44,14 @@ public: : wp(other.wp.internalData(), true) {} template = true> - QPointer &operator=(const QPointer &other) + QPointer &operator=(const QPointer &other) noexcept { QPointer(other).swap(*this); return *this; } template = true> - QPointer &operator=(QPointer &&other) + QPointer &operator=(QPointer &&other) noexcept { QPointer(std::move(other)).swap(*this); return *this;