diff --git a/src/gui/text/qtextformat.cpp b/src/gui/text/qtextformat.cpp index ce15389254..e7dcd3cb9c 100644 --- a/src/gui/text/qtextformat.cpp +++ b/src/gui/text/qtextformat.cpp @@ -2242,13 +2242,8 @@ void QTextBlockFormat::setTabPositions(const QList &tabs) { QList list; list.reserve(tabs.size()); - QList::ConstIterator iter = tabs.constBegin(); - while (iter != tabs.constEnd()) { - QVariant v; - v.setValue(*iter); - list.append(v); - ++iter; - } + for (const auto &e : tabs) + list.append(QVariant::fromValue(e)); setProperty(TabPositions, list); } @@ -2264,13 +2259,10 @@ QList QTextBlockFormat::tabPositions() const if (variant.isNull()) return QList(); QList answer; - QList variantsList = qvariant_cast >(variant); - QList::Iterator iter = variantsList.begin(); + const QList variantsList = qvariant_cast >(variant); answer.reserve(variantsList.size()); - while(iter != variantsList.end()) { - answer.append( qvariant_cast(*iter)); - ++iter; - } + for (const auto &e: variantsList) + answer.append(qvariant_cast(e)); return answer; }