whytofly
/
qt6-bb10
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix incorrect pass by value. 

Make sure we don't pass by value, but by const reference.

Change-Id: Ia432e881d2b8116f22a30dfa31186479784ee4a1
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>
bb10
Bjoern Breitmeyer 2015-03-18 18:11:44 +01:00 committed by Björn Breitmeyer
parent 60a384cf2f
commit 2e18c9af26
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
qmake/generators/win32/cesdkhandler.cpp
View File

@ -350,7 +350,7 @@ bool CeSdkHandler::retrieveAvailableSDKs()
return !m_list.empty();
}
QString CeSdkHandler::fixPaths(QString path) const
QString CeSdkHandler::fixPaths(const QString &path) const
{
QRegExp searchStr(QLatin1String("(\\$\\(\\w+\\))"));
QString fixedString = path;

2
qmake/generators/win32/cesdkhandler.h
View File

@ -76,9 +76,9 @@ public:
bool retrieveAvailableSDKs();
inline QList<CeSdkInfo> listAll() const { return m_list; }
private:
inline QString fixPaths(QString path) const;
void retrieveWEC6n7SDKs();
void retrieveWEC2013SDKs();
inline QString fixPaths(const QString &path) const;
QStringList getMsBuildToolPaths() const;
QStringList filterMsBuildToolPaths(const QStringList &paths) const;
bool parseMsBuildFile(QFile *file, CeSdkInfo *info);