From 318d39ccafc6ca4fa643bbf0b4b10a7d97ff1716 Mon Sep 17 00:00:00 2001 From: Mitch Curtis Date: Tue, 22 May 2012 16:08:08 +0200 Subject: [PATCH] Removed size comparison in QFileInfo::operator==. QTBUG-4031 and QTBUG-4036 mention that QFileInfo::operator== includes a size() comparison as part of its equality check. I've removed this check as it doesn't seem to be integral to the comparison. Task-number: QTBUG-4031 Task-number: QTBUG-4036 Change-Id: I5663ec0e1ac8f70e0a156357c284696779ecd380 Reviewed-by: Thiago Macieira --- src/corelib/io/qfileinfo.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/corelib/io/qfileinfo.cpp b/src/corelib/io/qfileinfo.cpp index 1dcde0496d..e533511a2b 100644 --- a/src/corelib/io/qfileinfo.cpp +++ b/src/corelib/io/qfileinfo.cpp @@ -415,9 +415,6 @@ bool QFileInfo::operator==(const QFileInfo &fileinfo) const sensitive = d->fileEngine->caseSensitive() ? Qt::CaseSensitive : Qt::CaseInsensitive; } - if (fileinfo.size() != size()) //if the size isn't the same... - return false; - // Fallback to expensive canonical path computation return canonicalFilePath().compare(fileinfo.canonicalFilePath(), sensitive) == 0; }