whytofly
/
qt6-bb10
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

QCommonStyle: replace a QPolygon with a QPoint[] (I) 

No need to allocate dynamic memory for a fixed-size point array
when QPainter has a (QPoint*,int) overload.

Change-Id: I50c69103bba47e9f6de4f5616e8f40fee522ddc2
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
bb10
Marc Mutz 2014-09-02 14:37:10 +02:00
parent e35841e374
commit 32a0e0cc61
1 changed files with 12 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/widgets/styles/qcommonstyle.cpp
View File

@ -321,22 +321,24 @@ void QCommonStyle::drawPrimitive(PrimitiveElement pe, const QStyleOption *opt, Q
if (const QStyleOptionHeader *header = qstyleoption_cast<const QStyleOptionHeader *>(opt)) {
QPen oldPen = p->pen();
if (header->sortIndicator & QStyleOptionHeader::SortUp) {
QPolygon pa(3);
p->setPen(QPen(opt->palette.light(), 0));
p->drawLine(opt->rect.x() + opt->rect.width(), opt->rect.y(),
opt->rect.x() + opt->rect.width() / 2, opt->rect.y() + opt->rect.height());
p->setPen(QPen(opt->palette.dark(), 0));
pa.setPoint(0, opt->rect.x() + opt->rect.width() / 2, opt->rect.y() + opt->rect.height());
pa.setPoint(1, opt->rect.x(), opt->rect.y());
pa.setPoint(2, opt->rect.x() + opt->rect.width(), opt->rect.y());
p->drawPolyline(pa);
const QPoint points[] = {
QPoint(opt->rect.x() + opt->rect.width() / 2, opt->rect.y() + opt->rect.height()),
QPoint(opt->rect.x(), opt->rect.y()),
QPoint(opt->rect.x() + opt->rect.width(), opt->rect.y()),
};
p->drawPolyline(points, sizeof points / sizeof *points);
} else if (header->sortIndicator & QStyleOptionHeader::SortDown) {
QPolygon pa(3);
p->setPen(QPen(opt->palette.light(), 0));
pa.setPoint(0, opt->rect.x(), opt->rect.y() + opt->rect.height());
pa.setPoint(1, opt->rect.x() + opt->rect.width(), opt->rect.y() + opt->rect.height());
pa.setPoint(2, opt->rect.x() + opt->rect.width() / 2, opt->rect.y());
p->drawPolyline(pa);
const QPoint points[] = {
QPoint(opt->rect.x(), opt->rect.y() + opt->rect.height()),
QPoint(opt->rect.x() + opt->rect.width(), opt->rect.y() + opt->rect.height()),
QPoint(opt->rect.x() + opt->rect.width() / 2, opt->rect.y()),
};
p->drawPolyline(points, sizeof points / sizeof *points);
p->setPen(QPen(opt->palette.dark(), 0));
p->drawLine(opt->rect.x(), opt->rect.y() + opt->rect.height(),
opt->rect.x() + opt->rect.width() / 2, opt->rect.y());