whytofly
/
qt6-bb10
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

QGenericRunnable: use CompactStorage 

...optimizing the storage of empty function objects.

Change-Id: I6db7384e1ebb87249d5b93922a6c92f0767cc401
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
bb10
Marc Mutz 2023-05-04 15:37:30 +02:00
parent b7780b5e5d
commit 3327fccfd5
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/corelib/thread/qrunnable.h
View File

@ -5,6 +5,7 @@
#define QRUNNABLE_H
#include <QtCore/qcompilerdetection.h>
#include <QtCore/qfunctionaltools_impl.h>
#include <functional>
#include <type_traits>
@ -54,14 +55,15 @@ protected:
};
template <typename Callable>
class QGenericRunnableHelper : public QGenericRunnableHelperBase
class QGenericRunnableHelper : public QGenericRunnableHelperBase,
private QtPrivate::CompactStorage<Callable>
{
Callable m_functionToRun;
using Storage = QtPrivate::CompactStorage<Callable>;
static void *impl(Op op, QGenericRunnableHelperBase *that, [[maybe_unused]] void *arg)
{
const auto _this = static_cast<QGenericRunnableHelper*>(that);
switch (op) {
case Op::Run: _this->m_functionToRun(); break;
case Op::Run: _this->object()(); break;
case Op::Destroy: delete _this; break;
}
return nullptr;
@ -70,7 +72,7 @@ protected:
template <typename UniCallable>
explicit QGenericRunnableHelper(UniCallable &&functionToRun) noexcept
: QGenericRunnableHelperBase(&impl),
m_functionToRun(std::forward<UniCallable>(functionToRun))
Storage{std::forward<UniCallable>(functionToRun)}
{
}
};