From 39de5717de868caa3368f44e871ce852dbbf390a Mon Sep 17 00:00:00 2001 From: Ahmad Samir Date: Sat, 17 Dec 2022 12:04:26 +0200 Subject: [PATCH] QSettings: get file timestamps in UTC directly These are timestamps, so UTC is all we need. This is faster than getting the times in the Local Time Zone just to compare them. Change-Id: I5ceebafea12a7015dce9e3c00d1b35f8da2afb1d Reviewed-by: Thiago Macieira --- src/corelib/io/qsettings.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/corelib/io/qsettings.cpp b/src/corelib/io/qsettings.cpp index a9919fdfa8..ccb50a83cd 100644 --- a/src/corelib/io/qsettings.cpp +++ b/src/corelib/io/qsettings.cpp @@ -1318,7 +1318,7 @@ void QConfFileSettingsPrivate::syncConfFile(QConfFile *confFile) */ if (readOnly && confFile->size > 0) { QFileInfo fileInfo(confFile->name); - if (confFile->size == fileInfo.size() && confFile->timeStamp == fileInfo.lastModified()) + if (confFile->size == fileInfo.size() && confFile->timeStamp == fileInfo.lastModified(QTimeZone::UTC)) return; } @@ -1361,7 +1361,7 @@ void QConfFileSettingsPrivate::syncConfFile(QConfFile *confFile) if (!readOnly) mustReadFile = (confFile->size != fileInfo.size() - || (confFile->size != 0 && confFile->timeStamp != fileInfo.lastModified())); + || (confFile->size != 0 && confFile->timeStamp != fileInfo.lastModified(QTimeZone::UTC))); if (mustReadFile) { confFile->unparsedIniSections.clear(); @@ -1407,7 +1407,7 @@ void QConfFileSettingsPrivate::syncConfFile(QConfFile *confFile) } confFile->size = fileInfo.size(); - confFile->timeStamp = fileInfo.lastModified(); + confFile->timeStamp = fileInfo.lastModified(QTimeZone::UTC); } /* @@ -1466,7 +1466,7 @@ void QConfFileSettingsPrivate::syncConfFile(QConfFile *confFile) QFileInfo fileInfo(confFile->name); confFile->size = fileInfo.size(); - confFile->timeStamp = fileInfo.lastModified(); + confFile->timeStamp = fileInfo.lastModified(QTimeZone::UTC); // If we have created the file, apply the file perms if (createFile) {