whytofly
/
qt6-bb10
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

QSqlTableModel::selectRow(): reduce scope of QSqlQuery 

It's good to clean up the query before emitting signals about the
updated row. It's possible that connected slots will call selectRow()
again for other rows.

Change-Id: I482fe2dd58218f53567ce8725ee591ce2eeda348
Reviewed-by: Andy Shaw <andy.shaw@digia.com>
Reviewed-by: Mark Brand <mabrand@mabrand.nl>
bb10
Mark Brand 2012-09-17 14:23:17 +02:00 committed by The Qt Project
parent 7389c09637
commit 3c2733e45f
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/sql/models/qsqltablemodel.cpp
View File

@ -431,13 +431,15 @@ bool QSqlTableModel::selectRow(int row)
d->sortColumn = table_sort_col;
d->filter = table_filter;
QSqlQuery q(d->db);
q.setForwardOnly(true);
if (!q.exec(stmt))
return false;
{
QSqlQuery q(d->db);
q.setForwardOnly(true);
if (!q.exec(stmt))
return false;
bool exists = q.next();
d->cache[row].refresh(exists, q.record());
bool exists = q.next();
d->cache[row].refresh(exists, q.record());
}
emit headerDataChanged(Qt::Vertical, row, row);
emit dataChanged(createIndex(row, 0), createIndex(row, columnCount() - 1));