From 42b8bbbef097626d2c7fc30097f7a5f904036860 Mon Sep 17 00:00:00 2001 From: Li Xinwei <1326710505@qq.com> Date: Mon, 17 May 2021 21:15:58 +0800 Subject: [PATCH] CMake: remove unnecessary add_dependencies() The dependencies to moc, uic and rcc have already been handled by qt_manual_moc(), qt_enable_autogen_tool() and _qt_internal_process_resource(). This allows not building some of the debug executables in a multi-config scenario. Task-number: QTBUG-88414 Change-Id: I6c162721f3ddf6b4b410345ad012073abbdfd9df Reviewed-by: Alexandru Croitor --- src/corelib/CMakeLists.txt | 4 ---- src/widgets/CMakeLists.txt | 2 -- 2 files changed, 6 deletions(-) diff --git a/src/corelib/CMakeLists.txt b/src/corelib/CMakeLists.txt index d193ec1b79..ab3de3b408 100644 --- a/src/corelib/CMakeLists.txt +++ b/src/corelib/CMakeLists.txt @@ -275,10 +275,6 @@ qt_update_ignore_pch_source(Core kernel/qmetatype.cpp ) # special case begin add_dependencies(Core qmodule_pri) -add_dependencies(Core ${QT_CMAKE_EXPORT_NAMESPACE}::moc) -add_dependencies(Core ${QT_CMAKE_EXPORT_NAMESPACE}::rcc) -add_dependencies(CorePrivate ${QT_CMAKE_EXPORT_NAMESPACE}::moc) -add_dependencies(CorePrivate ${QT_CMAKE_EXPORT_NAMESPACE}::rcc) if (NOT QT_NAMESPACE STREQUAL "") target_compile_definitions(Core PUBLIC "QT_NAMESPACE=${QT_NAMESPACE}") diff --git a/src/widgets/CMakeLists.txt b/src/widgets/CMakeLists.txt index 078e973dc8..3e5a4a9be0 100644 --- a/src/widgets/CMakeLists.txt +++ b/src/widgets/CMakeLists.txt @@ -65,8 +65,6 @@ qt_internal_add_module(Widgets "kernel/qt_widgets_pch.h" ) -add_dependencies(Widgets ${QT_CMAKE_EXPORT_NAMESPACE}::uic) # special case - # Resources: set(qstyle_resource_files "images/cdr-128.png"