From 43daefb0962794b2df256cae1098e889b9b36f12 Mon Sep 17 00:00:00 2001 From: Giuseppe D'Angelo Date: Mon, 24 Oct 2016 21:05:28 +0200 Subject: [PATCH] QStringListModel: fix corner-case in sibling() A negative row can be passed but should not result in a spurious index returned. Change-Id: I57f180615020d24826e9b3807557ba172ed469c3 Reviewed-by: Marc Mutz --- src/corelib/itemmodels/qstringlistmodel.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/corelib/itemmodels/qstringlistmodel.cpp b/src/corelib/itemmodels/qstringlistmodel.cpp index 0f7472aa5a..da232cc142 100644 --- a/src/corelib/itemmodels/qstringlistmodel.cpp +++ b/src/corelib/itemmodels/qstringlistmodel.cpp @@ -131,7 +131,7 @@ int QStringListModel::rowCount(const QModelIndex &parent) const */ QModelIndex QStringListModel::sibling(int row, int column, const QModelIndex &idx) const { - if (!idx.isValid() || column != 0 || row >= lst.count()) + if (!idx.isValid() || column != 0 || row >= lst.count() || row < 0) return QModelIndex(); return createIndex(row, 0);