whytofly
/
qt6-bb10
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

QHttp2ProtocolHandler: optimize updateStream 

Use QBAV more to reduce allocations

Change-Id: I009144156fafa64dd241c446bd4081fe197aa2bf
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
bb10
Anton Kudryavtsev 2023-11-01 14:46:55 +03:00
parent 567e9b2026
commit 457309c9fa
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/network/access/qhttp2protocolhandler.cpp
View File

@ -1098,7 +1098,7 @@ void QHttp2ProtocolHandler::updateStream(Stream &stream, const HPack::HttpHeader
int statusCode = 0;
for (const auto &pair : headers) {
const auto &name = pair.name;
auto value = pair.value;
const auto value = QByteArrayView(pair.value);
// TODO: part of this code copies what SPDY protocol handler does when
// processing headers. Binary nature of HTTP/2 and SPDY saves us a lot
@ -1118,10 +1118,8 @@ void QHttp2ProtocolHandler::updateStream(Stream &stream, const HPack::HttpHeader
if (ok)
httpReply->setContentLength(length);
} else {
QByteArray binder(", ");
if (name == "set-cookie")
binder = "\n";
httpReply->appendHeaderField(name, value.replace('\0', binder));
const auto binder = name == "set-cookie" ? QByteArrayView("\n") : QByteArrayView(", ");
httpReply->appendHeaderField(name, QByteArray(pair.value).replace('\0', binder));
}
}