QCoffPeParser: simplify std::optional check

Even in C++98 one could declare variables in if statements and
contextually convert them to bool:

   if (D* d = dynamic_cast<D*>(base))
      ~~~
   else if (D2* d = dynamic_cast<D2*>(base))
      ~~~

std::optional is contextually convertible to bool, so we don't need
C++17 if initializers. Just use

   if (auto optional = ~~~~)

Pick-to: 6.3
Change-Id: Ie64c2c1ceb7b608eda0534d837f46d3c4be49bf8
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
bb10
Marc Mutz 2022-01-30 21:04:53 +01:00
parent 0d9f4e7526
commit 472722382d
1 changed files with 1 additions and 1 deletions

View File

@ -364,7 +364,7 @@ QLibraryScanResult QCoffPeParser::parse(QByteArrayView data, QString *errMsg)
return {};
QByteArrayView stringTable;
if (auto optional = findStringTable(data, ntHeaders, error); optional)
if (auto optional = findStringTable(data, ntHeaders, error))
stringTable = *optional;
else
return {};