whytofly
/
qt6-bb10
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve tst_qtimeline::value 

The test was improved by:
 - Use QCOMPARE instead of QVERIFY
 - Use QTRY_ macro instead arbitrary qWait
 - Use longer time line

The test executes faster and it should be less vulnerable to
an unreliable timer.

Change-Id: I92675015a6251b47eaf20b0fc916f3a36b52d783
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@theqtcompany.com>
bb10
Jędrzej Nowacki 2015-12-14 13:23:47 +01:00
parent 266511401f
commit 4e012cb083
1 changed files with 7 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
tests/auto/corelib/tools/qtimeline/tst_qtimeline.cpp
View File

@ -198,31 +198,27 @@ void tst_QTimeLine::frameRate()
void tst_QTimeLine::value()
{
QTimeLine timeLine(2000);
QVERIFY(timeLine.currentValue() == 0.0);
QTimeLine timeLine(5000);
QCOMPARE(timeLine.currentValue(), 0.0);
// Default speed
QSignalSpy spy(&timeLine, &QTimeLine::valueChanged);
QVERIFY(spy.isValid());
timeLine.start();
QTest::qWait(timeLine.duration()/3);
QVERIFY(timeLine.currentValue() > 0);
QTest::qWait(timeLine.duration());
QCOMPARE(timeLine.state(), QTimeLine::NotRunning);
qreal currentValue = timeLine.currentValue();
QVERIFY(currentValue == 1);
QTRY_VERIFY(timeLine.currentValue() > 0);
QTRY_COMPARE(timeLine.state(), QTimeLine::NotRunning);
QCOMPARE(timeLine.currentValue(), 1.0);
QVERIFY(spy.count() > 0);
// Reverse should decrease the value
timeLine.setCurrentTime(100);
timeLine.start();
// Let it update on its own
QTest::qWait(500);
QCOMPARE(timeLine.state(), QTimeLine::Running);
QTRY_VERIFY(timeLine.currentValue());
qreal value = timeLine.currentValue();
timeLine.setDirection(QTimeLine::Backward);
QTest::qWait(1000);
QVERIFY(timeLine.currentValue() < value);
QTRY_VERIFY(timeLine.currentValue() < value);
timeLine.stop();
}