whytofly
/
qt6-bb10
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove noop calls to QPlatformInputContext base class 

Like most QPlatformFoo base classes the default implementations are
empty, or have default behavior that should be completely replaced
by subclasses.

By making it consistent across all the platform plugins when we call
base class methods, we avoid confusion of whether a base class call
is needed or not.

Change-Id: Idd8e4a6fa0e24a1dffd21b63471c9b1c2348691f
Reviewed-by: Doris Verria <doris.verria@qt.io>
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
bb10
Tor Arne Vestbø 2022-04-21 14:46:25 +02:00
parent 3aeeb8d113
commit 4f72db2fce
4 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/platforminputcontexts/ibus/qibusplatforminputcontext.cpp
View File

@ -180,8 +180,6 @@ void QIBusPlatformInputContext::invokeAction(QInputMethod::Action a, int)
void QIBusPlatformInputContext::reset()
{
QPlatformInputContext::reset();
if (!d->busConnected)
return;
@ -192,8 +190,6 @@ void QIBusPlatformInputContext::reset()
void QIBusPlatformInputContext::commit()
{
QPlatformInputContext::commit();
if (!d->busConnected)
return;
@ -242,7 +238,6 @@ void QIBusPlatformInputContext::update(Qt::InputMethodQueries q)
d->context->SetSurroundingText(dbusText, cursorPosition, anchorPosition);
}
QPlatformInputContext::update(q);
}
void QIBusPlatformInputContext::cursorRectChanged()

1
src/plugins/platforms/android/qandroidinputcontext.cpp
View File

@ -979,7 +979,6 @@ void QAndroidInputContext::setFocusObject(QObject *object)
m_focusObject = object;
reset();
}
QPlatformInputContext::setFocusObject(object);
updateSelectionHandles();
}

2
src/plugins/platforms/cocoa/qcocoainputcontext.mm
View File

@ -136,8 +136,6 @@ void QCocoaInputContext::reset()
{
qCDebug(lcQpaInputMethods) << "Resetting input method";
QPlatformInputContext::reset();
if (!m_focusWindow)
return;

2
src/plugins/platforms/windows/qwindowsinputcontext.cpp
View File

@ -197,7 +197,6 @@ bool QWindowsInputContext::hasCapability(Capability capability) const
void QWindowsInputContext::reset()
{
QPlatformInputContext::reset();
if (!m_compositionContext.hwnd)
return;
qCDebug(lcQpaInputMethods) << __FUNCTION__;
@ -335,7 +334,6 @@ void QWindowsInputContext::update(Qt::InputMethodQueries queries)
{
if (queries & Qt::ImEnabled)
updateEnabled();
QPlatformInputContext::update(queries);
}
void QWindowsInputContext::cursorRectChanged()