From 4fa94440902d87b41f6cda7e5fd057dc8e79f08d Mon Sep 17 00:00:00 2001
From: Albert Astals Cid <albert.astals.cid@kdab.com>
Date: Thu, 7 May 2020 16:13:32 +0200
Subject: [PATCH] QByteArrayLiteral: Remove const temporary that may prevent
 optimization

clang-tidy 10 was complaining about
http://clang.llvm.org/extra/clang-tidy/checks/performance-no-automatic-move.html

Pick-To: 5.15
Change-Id: I63ba4111e01bb9d3ee87940253c4a79cc42c0bdf
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
---
 src/corelib/text/qbytearray.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/corelib/text/qbytearray.h b/src/corelib/text/qbytearray.h
index 55d4c87e92..bc4b0b3763 100644
--- a/src/corelib/text/qbytearray.h
+++ b/src/corelib/text/qbytearray.h
@@ -125,8 +125,7 @@ using QByteArrayData = QArrayDataPointer<char>;
             static_cast<QTypedArrayData<char> *>(const_cast<QArrayData *>(&qbytearray_literal)), \
             const_cast<char *>(str), \
             Size }; \
-        const QByteArray ba(holder); \
-        return ba; \
+        return QByteArray(holder); \
     }()) \
     /**/