From 51edc438dd88d3260b6d824a95d4b4782c59fb03 Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Fri, 14 Jul 2023 20:00:13 +0200 Subject: [PATCH] tst_QAbstractItemModelTester: fix mem-leak QThreeWidgetItems that have been removed from their parents (or the widget) must be deleted manually. The treeWidgetModel() test forgot that, driving asan nuts. Code predates the beginning of the public history, so picking to all active branches. Pick-to: 6.6 6.5 6.2 5.15 Change-Id: I139549b0bd8baf4abfb90f926f6290119471046f Reviewed-by: Ivan Solovev --- .../qabstractitemmodeltester/tst_qabstractitemmodeltester.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/auto/testlib/qabstractitemmodeltester/tst_qabstractitemmodeltester.cpp b/tests/auto/testlib/qabstractitemmodeltester/tst_qabstractitemmodeltester.cpp index a7c90da6a9..ad146c526d 100644 --- a/tests/auto/testlib/qabstractitemmodeltester/tst_qabstractitemmodeltester.cpp +++ b/tests/auto/testlib/qabstractitemmodeltester/tst_qabstractitemmodeltester.cpp @@ -54,6 +54,7 @@ void tst_QAbstractItemModelTester::treeWidgetModel() new QTreeWidgetItem(root, QStringList(QString::number(i))); QTreeWidgetItem *remove = root->child(2); root->removeChild(remove); + delete remove; QTreeWidgetItem *parent = new QTreeWidgetItem(&widget, QStringList("parent")); new QTreeWidgetItem(parent, QStringList("child")); parent->setHidden(true);