From 528e70b6d9333348044ecffb7bab8edfe9006538 Mon Sep 17 00:00:00 2001 From: Alexandru Croitor Date: Fri, 8 Sep 2023 11:51:58 +0200 Subject: [PATCH] CMake: Add CFBundleIconName key to ios assets manual tests It is required for publishing an app to the app store. Otherwise during app store validation phase, you get an error: Asset validation failed Missing Info.plist value. A value for the Info.plist key 'CFBundleIconName' is missing in the bundle 'foo'. Apps built with iOS 11 or later SDK must supply app icons in an asset catalog and must also provide a value for this Info.plist key. For more information see http://help.apple.com/xcode/mac/current/#/dev10510b1f7. Note this is not needed when using Xcode 14.3+ and when one places the icons into an asset catalog. When processing icons in the asset catalog, Xcode generates a partial Info.plist file that will contain the CFBundleIconName key and will merge into the final Info.plist file. Amends cf3535fdf2e7fe52b36aaa4b94a53525fd6640f4 Pick-to: 6.5 6.6 Task-number: QTBUG-104519 Task-number: QTBUG-110921 Task-number: QTBUG-116784 Change-Id: I53009097cf27b096c72ee9c4bad6aa4286272061 Reviewed-by: Alexey Edelev Reviewed-by: Amir Masoud Abdol --- tests/manual/ios_assets/Info.ios.cmake.plist | 2 ++ tests/manual/ios_assets/Info.ios.qmake.plist | 2 ++ 2 files changed, 4 insertions(+) diff --git a/tests/manual/ios_assets/Info.ios.cmake.plist b/tests/manual/ios_assets/Info.ios.cmake.plist index 2b2bb69522..aa4c68dec4 100644 --- a/tests/manual/ios_assets/Info.ios.cmake.plist +++ b/tests/manual/ios_assets/Info.ios.cmake.plist @@ -64,6 +64,8 @@ AppIcon57x57@2x.png AppIcon60x60@2x.png + CFBundleIconName + AppIcon CFBundleIcons~ipad diff --git a/tests/manual/ios_assets/Info.ios.qmake.plist b/tests/manual/ios_assets/Info.ios.qmake.plist index e97150e47b..cacfa49db3 100644 --- a/tests/manual/ios_assets/Info.ios.qmake.plist +++ b/tests/manual/ios_assets/Info.ios.qmake.plist @@ -47,6 +47,8 @@ AppIcon57x57@2x.png AppIcon60x60@2x.png + CFBundleIconName + AppIcon CFBundleIcons~ipad