From 56a8c277546fba6ad45711e95db26c74178ef512 Mon Sep 17 00:00:00 2001 From: Lars Knoll Date: Tue, 12 Feb 2019 09:53:11 +0100 Subject: [PATCH] Remove bogus assert MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The code was actually completely fine, but the assert was bogus. detach() can call realloc(d->alloc). Fixes: QTBUG-73756 Change-Id: I3485bc926dba3f2537e14c0c05d30ff982e6e714 Reviewed-by: MÃ¥rten Nordheim Reviewed-by: Thiago Macieira --- src/corelib/tools/qvector.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/corelib/tools/qvector.h b/src/corelib/tools/qvector.h index b51cd819c5..988d5a9e1b 100644 --- a/src/corelib/tools/qvector.h +++ b/src/corelib/tools/qvector.h @@ -672,7 +672,6 @@ void QVector::realloc(int aalloc, QArrayData::AllocationOptions options) Data *x = d; const bool isShared = d->ref.isShared(); - Q_ASSERT(aalloc != int(d->alloc) || isShared); QT_TRY { // allocate memory