From 582bb9e467d6bfca3a8a525e478c51cd645a4bc0 Mon Sep 17 00:00:00 2001 From: Jo Asplin Date: Wed, 9 Nov 2011 17:05:51 +0100 Subject: [PATCH] Re-enabled passing tests in tst_qabstractprintdialog To increase the effective test coverage, this patch re-enables the tst_qabstractprintdialog test case as such, and instead disables only the test functions that are currently failing in CI. Task-number: QTBUG-22453 Change-Id: Ic09a03ed405bf6f85917410a7a86e17f2fe22cba Reviewed-by: Jason McDonald --- .../dialogs/qabstractprintdialog/qabstractprintdialog.pro | 2 -- .../dialogs/qabstractprintdialog/tst_qabstractprintdialog.cpp | 1 + 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/auto/widgets/dialogs/qabstractprintdialog/qabstractprintdialog.pro b/tests/auto/widgets/dialogs/qabstractprintdialog/qabstractprintdialog.pro index 2bc20156c1..b867610009 100644 --- a/tests/auto/widgets/dialogs/qabstractprintdialog/qabstractprintdialog.pro +++ b/tests/auto/widgets/dialogs/qabstractprintdialog/qabstractprintdialog.pro @@ -6,5 +6,3 @@ CONFIG += testcase TARGET = tst_qabstractprintdialog QT += widgets printsupport testlib SOURCES += tst_qabstractprintdialog.cpp - -CONFIG += insignificant_test # QTBUG-21402 diff --git a/tests/auto/widgets/dialogs/qabstractprintdialog/tst_qabstractprintdialog.cpp b/tests/auto/widgets/dialogs/qabstractprintdialog/tst_qabstractprintdialog.cpp index 5973dabb99..a0020acbf6 100644 --- a/tests/auto/widgets/dialogs/qabstractprintdialog/tst_qabstractprintdialog.cpp +++ b/tests/auto/widgets/dialogs/qabstractprintdialog/tst_qabstractprintdialog.cpp @@ -114,6 +114,7 @@ void tst_QAbstractPrintDialog::setMinMax() QPrinter printer; MyAbstractPrintDialog obj1(&printer); obj1.setEnabledOptions(QAbstractPrintDialog::PrintDialogOptions(QAbstractPrintDialog::None)); + QEXPECT_FAIL("", "QTBUG-22637", Abort); QCOMPARE(obj1.minPage(), 1); QCOMPARE(obj1.maxPage(), INT_MAX); QVERIFY(!obj1.isOptionEnabled(QAbstractPrintDialog::PrintPageRange));