From 585758389c64e556ef4808308dee27e19241581e Mon Sep 17 00:00:00 2001 From: Tobias Hunger Date: Thu, 29 Aug 2013 11:40:48 +0200 Subject: [PATCH] Graphicsview: Simplify code order is either Ascending or Descending (0 or 1), so this comparison is unnecessary. Change-Id: Ieceacf18f1bf3c7a7555205a140b738daa92bd04 Reviewed-by: Stephen Kelly Reviewed-by: Robin Burchell --- src/widgets/graphicsview/qgraphicsscenebsptreeindex.cpp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/widgets/graphicsview/qgraphicsscenebsptreeindex.cpp b/src/widgets/graphicsview/qgraphicsscenebsptreeindex.cpp index f70e66f685..7598163f2d 100644 --- a/src/widgets/graphicsview/qgraphicsscenebsptreeindex.cpp +++ b/src/widgets/graphicsview/qgraphicsscenebsptreeindex.cpp @@ -567,10 +567,7 @@ QList QGraphicsSceneBspTreeIndex::items(Qt::SortOrder order) co itemList << item; } } - if (order != -1) { - //We sort descending order - d->sortItems(&itemList, order, d->sortCacheEnabled); - } + d->sortItems(&itemList, order, d->sortCacheEnabled); return itemList; }