From 5cf94bcc2fe553acec481583fc2462bd5c0884ca Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=C3=A5rten=20Nordheim?= Date: Mon, 15 Apr 2024 17:42:24 +0200 Subject: [PATCH] QSaveFile[win]: store error in nativeRenameOverwrite We want to drop the fallback path, so we need to set an appropriate error when the native rename fails. Change-Id: I2746d79b9e5666f54c35ff7ac29a74191cf22740 Reviewed-by: Thiago Macieira --- src/corelib/io/qfsfileengine_win.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/corelib/io/qfsfileengine_win.cpp b/src/corelib/io/qfsfileengine_win.cpp index d3439d61fa..20f6f8e8ff 100644 --- a/src/corelib/io/qfsfileengine_win.cpp +++ b/src/corelib/io/qfsfileengine_win.cpp @@ -419,10 +419,10 @@ bool QFSFileEnginePrivate::nativeRenameOverwrite(const QString &newName) bool res = SetFileInformationByHandle(fileHandle, FileRenameInfo, renameInfo, DWORD(renameDataSize)); -#if 0 - if (!res) - qErrnoWarning("QFSFileEnginePrivate::nativeRenameOverwrite failed"); -#endif + if (!res) { + DWORD error = GetLastError(); + q_func()->setError(QFile::RenameError, qt_error_string(int(error))); + } return res; }