From 5d89dda2df2d4c264b4eddb4a83a7173d72f4eb7 Mon Sep 17 00:00:00 2001 From: Edward Welbourne Date: Tue, 13 Sep 2022 16:46:27 +0200 Subject: [PATCH] Apply NRVO to QTimeZonePrivate::windowsIdToIanaIds() Change-Id: Iba62f25a187d00b4b9ade1a4a5e063b62b653379 Reviewed-by: Thiago Macieira --- src/corelib/time/qtimezoneprivate.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/corelib/time/qtimezoneprivate.cpp b/src/corelib/time/qtimezoneprivate.cpp index 1895e9bf71..ab3a4e395d 100644 --- a/src/corelib/time/qtimezoneprivate.cpp +++ b/src/corelib/time/qtimezoneprivate.cpp @@ -685,19 +685,19 @@ QList QTimeZonePrivate::windowsIdToIanaIds(const QByteArray &windows QList QTimeZonePrivate::windowsIdToIanaIds(const QByteArray &windowsId, QLocale::Territory territory) { + QList list; const quint16 windowsIdKey = toWindowsIdKey(windowsId); const qint16 land = static_cast(territory); for (const QZoneData &data : zoneDataTable) { // Return the region matches in preference order if (data.windowsIdKey == windowsIdKey && data.territory == land) { - QList list; for (auto l1 : data.ids()) list << QByteArray(l1.data(), l1.size()); - return list; + break; } } - return QList(); + return list; } // Define template for derived classes to reimplement so QSharedDataPointer clone() works correctly