whytofly
/
qt6-bb10
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tls: use string view types more 

Prefer QStringView overloads

Change-Id: Icc928a91056d661f9e7f187f42592f05ad081a84
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
bb10
Anton Kudryavtsev 2023-08-17 14:55:25 +03:00 committed by Anton Kudryavtsev
parent 600d16df22
commit 5dc068e95a
3 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/tls/openssl/qtls_openssl.cpp
View File

@ -92,7 +92,7 @@ QSslCertificate findCertificateToFetch(const QList<QSslError> &tlsErrors, bool c
if (checkAIA) {
const auto extensions = certToFetch.extensions();
for (const auto &ext : extensions) {
if (ext.oid() == QStringLiteral("1.3.6.1.5.5.7.1.1")) // See RFC 4325
if (ext.oid() == u"1.3.6.1.5.5.7.1.1") // See RFC 4325
return certToFetch;
}
//The only reason we check this extensions is because an application set trusted

3
src/plugins/tls/schannel/qtls_schannel.cpp
View File

@ -805,8 +805,7 @@ bool netscapeWrongCertType(const QList<QSslCertificateExtension> &extensions, bo
const auto netscapeIt = std::find_if(
extensions.cbegin(), extensions.cend(),
[](const QSslCertificateExtension &extension) {
const auto netscapeCertType = QStringLiteral("2.16.840.1.113730.1.1");
return extension.oid() == netscapeCertType;
return extension.oid() == u"2.16.840.1.113730.1.1";
});
if (netscapeIt != extensions.cend()) {
const QByteArray netscapeCertTypeByte = netscapeIt->value().toByteArray();

4
src/plugins/tls/shared/qasn1element.cpp
View File

@ -225,7 +225,7 @@ QDateTime QAsn1Element::toDateTime() const
if (mType == UtcTimeType && mValue.size() == 13) {
result = QDateTime::fromString(QString::fromLatin1(mValue),
QStringLiteral("yyMMddHHmmsst"));
u"yyMMddHHmmsst");
if (!result.isValid())
return result;
@ -248,7 +248,7 @@ QDateTime QAsn1Element::toDateTime() const
Q_ASSERT(result.date().year() <= 2049);
} else if (mType == GeneralizedTimeType && mValue.size() == 15) {
result = QDateTime::fromString(QString::fromLatin1(mValue),
QStringLiteral("yyyyMMddHHmmsst"));
u"yyyyMMddHHmmsst");
}
return result;