whytofly
/
qt6-bb10
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tracepointgen: fix inefficient loops 

Take the loop variable by cref, avoid some QList detaching.

Coverity-Id: 404697
Coverity-Id: 404697
Coverity-Id: 404699
Coverity-Id: 404700
Pick-to: 6.5
Change-Id: I9fe7b6ad3cf87f442e6c111d6f661122ac23769c
Reviewed-by: Antti Määttä <antti.maatta@qt.io>
bb10
Marc Mutz 2023-03-10 18:38:14 +01:00
parent 595ac662ed
commit 60c3aaa54f
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/tools/tracepointgen/parser.cpp
View File

@ -240,7 +240,7 @@ QStringList Parser::findEnumValues(const QString &name, const QStringList &inclu
QString enumName = split.last();
DEBUGPRINTF(printf("searching for %s\n", qPrintable(name)));
QStringList ret;
for (auto filename : includes) {
for (const QString &filename : includes) {
QFile input(filename);
if (!input.open(QIODevice::ReadOnly | QIODevice::Text)) {
DEBUGPRINTF(printf("Cannot open '%s' for reading: %s\n",
@ -300,8 +300,8 @@ QStringList Parser::findEnumValues(const QString &name, const QStringList &inclu
int begin = data.indexOf(QLatin1Char('{'), match.capturedEnd());
int end = data.indexOf(QLatin1Char('}'), begin);
QString block = data.mid(begin + 1, end - begin - 1);
QStringList enums = block.split(QLatin1Char('\n'));
for (auto e : enums) {
const QStringList enums = block.split(QLatin1Char('\n'));
for (const auto &e : enums) {
const auto trimmed = e.trimmed();
if (!trimmed.isEmpty() && !trimmed.startsWith(QLatin1Char('#')))
ret << trimmed;
@ -327,7 +327,7 @@ static QList<EnumNameValue> enumsToValues(const QStringList &values)
{
int cur = 0;
QList<EnumNameValue> ret;
for (auto value : values) {
for (const QString &value : values) {
EnumNameValue r;
if (value.contains(QLatin1Char('='))) {
size_t offset = value.indexOf(QLatin1Char('='));
@ -438,8 +438,8 @@ void Parser::parseMetadata(const QString &data, qsizetype offset, const QStringL
return a.value < b.value;
});
values.clear();
int prevValue = moreValues.first().value;
for (auto v : moreValues) {
int prevValue = std::as_const(moreValues).front().value;
for (const auto &v : std::as_const(moreValues)) {
QString a;
if (v.valueStr.isNull()) {
if (v.value == prevValue + 1 && !flags)