From 63c1e7c4a105df0b61f0cd1f8193820cdf026ae3 Mon Sep 17 00:00:00 2001 From: Ievgenii Meshcheriakov Date: Fri, 3 Sep 2021 14:38:44 +0200 Subject: [PATCH] QUrl: Remove explicit casts to {const,} void* Those casts are not needed when passing pointers to simple types to memcpy. Change-Id: I686265b0e152aa22e0195ff252c442ab1a122ba7 Reviewed-by: Edward Welbourne Reviewed-by: Thiago Macieira --- src/corelib/io/qurlrecode.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/corelib/io/qurlrecode.cpp b/src/corelib/io/qurlrecode.cpp index fd5accb108..985e4b5c28 100644 --- a/src/corelib/io/qurlrecode.cpp +++ b/src/corelib/io/qurlrecode.cpp @@ -591,7 +591,7 @@ static qsizetype decode(QString &appendTo, QStringView in) const int origSize = appendTo.size(); appendTo.resize(origSize + (end - begin)); QChar *output = appendTo.data() + origSize; - memcpy(static_cast(output), static_cast(begin), (input - begin) * sizeof(QChar)); + memcpy(output, begin, (input - begin) * sizeof(QChar)); output += input - begin; while (input != end) { @@ -601,8 +601,7 @@ static qsizetype decode(QString &appendTo, QStringView in) if (Q_UNLIKELY(end - input < 3 || !isHex(input[1]) || !isHex(input[2]))) { // badly-encoded data appendTo.resize(origSize + (end - begin)); - memcpy(static_cast(appendTo.begin() + origSize), - static_cast(begin), (end - begin) * sizeof(*end)); + memcpy(appendTo.begin() + origSize, begin, (end - begin) * sizeof(*end)); return end - begin; }