From 65c40615d1cca1476dc647aa25abb94efe0b5272 Mon Sep 17 00:00:00 2001 From: Mate Barany Date: Tue, 20 Sep 2022 17:57:35 +0200 Subject: [PATCH] qdbusxml2cpp: Drop extra QString() This commit addresses a comment from the review of QTBUG-98434. Drop the extra QString(), .arg can be called on _L1 as well. Task-number: QTBUG-103100 Change-Id: I4891d42536f6ea413464bea78de4b82aa6363a11 Reviewed-by: Marc Mutz --- src/tools/qdbusxml2cpp/qdbusxml2cpp.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tools/qdbusxml2cpp/qdbusxml2cpp.cpp b/src/tools/qdbusxml2cpp/qdbusxml2cpp.cpp index 8bed1d8d90..1da650a340 100644 --- a/src/tools/qdbusxml2cpp/qdbusxml2cpp.cpp +++ b/src/tools/qdbusxml2cpp/qdbusxml2cpp.cpp @@ -284,7 +284,7 @@ static QString constRefArg(const QByteArray &arg) if (!arg.startsWith('Q')) return QLatin1StringView(arg + ' '); else - return QString("const %1 &"_L1).arg(QLatin1StringView(arg)); + return "const %1 &"_L1.arg(QLatin1StringView(arg)); } static QStringList makeArgNames(const QDBusIntrospection::Arguments &inputArgs,