From 6c36fd8af7e873defa3843f49848a14980561647 Mon Sep 17 00:00:00 2001 From: Lars Knoll Date: Tue, 16 Jun 2020 10:55:11 +0200 Subject: [PATCH] Make QVariant(Type) and QVariant(QDataStream) explicit MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We should probably deprecate both constructors in addition. Change-Id: Id62448b2abe14248c134feae899fa053ef373e58 Reviewed-by: Thiago Macieira Reviewed-by: MÃ¥rten Nordheim --- src/corelib/kernel/qvariant.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/corelib/kernel/qvariant.h b/src/corelib/kernel/qvariant.h index 78870458f9..c8042b5ab1 100644 --- a/src/corelib/kernel/qvariant.h +++ b/src/corelib/kernel/qvariant.h @@ -207,12 +207,12 @@ class Q_CORE_EXPORT QVariant QVariant() noexcept : d() {} ~QVariant(); - QVariant(Type type); + explicit QVariant(Type type); explicit QVariant(QMetaType type, const void *copy = nullptr); QVariant(const QVariant &other); #ifndef QT_NO_DATASTREAM - QVariant(QDataStream &s); + explicit QVariant(QDataStream &s); #endif QVariant(int i);