From 6fa50601ab7c55946eecc33453e7d694b5940d8d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tor=20Arne=20Vestb=C3=B8?= Date: Thu, 23 Apr 2020 11:04:58 +0200 Subject: [PATCH] Don't warn when loading icons via the image loaders MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 9d5ae9f26c98 introduced a warning when a matching icon engine was not found for a given file suffix, under the assumption that all formats would go through icon engine plugins. Unfortunately QIcon itself falls back to a direct use of QPixmapIconEngine when no icon engine plugin is found, which would lead to the warning being emitted for built in formats such as PNG. Until this code can be moved properly into QPixmapIconEngine we'll remove it. Change-Id: I14d1d33a0f0c29e4b4604ef3b53c05cb8e02f867 Reviewed-by: Tor Arne Vestbø Reviewed-by: Simon Hausmann --- src/gui/image/qicon.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/gui/image/qicon.cpp b/src/gui/image/qicon.cpp index 562e5e9a3e..41fe649fc5 100644 --- a/src/gui/image/qicon.cpp +++ b/src/gui/image/qicon.cpp @@ -1049,8 +1049,6 @@ static QIconEngine *iconEngineFromSuffix(const QString &fileName, const QString } } } - qWarning("Could not find icon engine for suffix '%s' of file '%s'", - qUtf8Printable(suffix), qUtf8Printable(fileName)); return nullptr; }