From 7071010880191e07fbcfd8aac876e396b462f956 Mon Sep 17 00:00:00 2001 From: Even Oscar Andersen Date: Fri, 15 Mar 2024 14:16:05 +0100 Subject: [PATCH] wasm: Add qdiriterator test + minor runtime fixes There was a runtime feilure in that we try to create directories until it fails. This does not fail on wasm so added a hardlimit of 20480 Change-Id: I6ef65f7be277fc8775879733f969d2ce008a439a Reviewed-by: Lorn Potter --- tests/auto/CMakeLists.txt | 1 + .../corelib/io/qdiriterator/tst_qdiriterator.cpp | 16 ++++++++++++---- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/tests/auto/CMakeLists.txt b/tests/auto/CMakeLists.txt index 9a590cf93c..06e9b9ac6c 100644 --- a/tests/auto/CMakeLists.txt +++ b/tests/auto/CMakeLists.txt @@ -57,6 +57,7 @@ if(QT_BUILD_MINIMAL_ANDROID_MULTI_ABI_TESTS) endif() if(WASM) + add_subdirectory(corelib/io/qdiriterator) add_subdirectory(corelib/io/largefile) add_subdirectory(corelib/io/qdataurl) add_subdirectory(corelib/io/qbuffer) diff --git a/tests/auto/corelib/io/qdiriterator/tst_qdiriterator.cpp b/tests/auto/corelib/io/qdiriterator/tst_qdiriterator.cpp index 9a17ae4994..239cb759e8 100644 --- a/tests/auto/corelib/io/qdiriterator/tst_qdiriterator.cpp +++ b/tests/auto/corelib/io/qdiriterator/tst_qdiriterator.cpp @@ -533,8 +533,15 @@ void tst_QDirIterator::longPath() while (dir.exists(dirName) || dir.mkdir(dirName)) { ++n; dirName.append('x'); + if (n >= 20480) + { + break; + } + } + if (n >= 20480) + { + qWarning("No maximum length on directory names"); } - QDirIterator it(dir.absolutePath(), QDir::NoDotAndDotDot|QDir::Dirs, QDirIterator::Subdirectories); int m = 0; while (it.hasNext()) { @@ -543,13 +550,14 @@ void tst_QDirIterator::longPath() } QCOMPARE(n, m); - dirName.chop(1); while (dirName.size() > 0 && dir.exists(dirName) && dir.rmdir(dirName)) { + --n; dirName.chop(1); } - dir.cdUp(); - dir.rmdir("longpaths"); + QCOMPARE(n, 0); + QVERIFY(dir.cdUp()); + QVERIFY(dir.rmdir("longpaths")); } void tst_QDirIterator::dirorder()