From 71ba53e3a7b63da1ac8755dba8b9311774d46103 Mon Sep 17 00:00:00 2001 From: JiDe Zhang Date: Tue, 28 Sep 2021 17:46:16 +0800 Subject: [PATCH] Fix memory leak Destroy the QDBusPendingCallWatcher object when received the QDBusPendingCallWatcher::finished signal later. Pick-to: 5.15 6.2 Change-Id: I1ec67bf7c286f38200c374ad92df2a1579588a8a Reviewed-by: Thiago Macieira --- .../xdgdesktopportal/qxdgdesktopportalfiledialog.cpp | 1 + .../platformthemes/xdgdesktopportal/qxdgdesktopportaltheme.cpp | 1 + 2 files changed, 2 insertions(+) diff --git a/src/plugins/platformthemes/xdgdesktopportal/qxdgdesktopportalfiledialog.cpp b/src/plugins/platformthemes/xdgdesktopportal/qxdgdesktopportalfiledialog.cpp index 85bdd1ab88..66e374f621 100644 --- a/src/plugins/platformthemes/xdgdesktopportal/qxdgdesktopportalfiledialog.cpp +++ b/src/plugins/platformthemes/xdgdesktopportal/qxdgdesktopportalfiledialog.cpp @@ -302,6 +302,7 @@ void QXdgDesktopPortalFileDialog::openPortal() this, SLOT(gotResponse(uint,QVariantMap))); } + watcher->deleteLater(); }); } diff --git a/src/plugins/platformthemes/xdgdesktopportal/qxdgdesktopportaltheme.cpp b/src/plugins/platformthemes/xdgdesktopportal/qxdgdesktopportaltheme.cpp index fb324afbd8..2fc3167fd5 100644 --- a/src/plugins/platformthemes/xdgdesktopportal/qxdgdesktopportaltheme.cpp +++ b/src/plugins/platformthemes/xdgdesktopportal/qxdgdesktopportaltheme.cpp @@ -111,6 +111,7 @@ QXdgDesktopPortalTheme::QXdgDesktopPortalTheme() if (reply.isValid()) { d->fileChooserPortalVersion = reply.value().toUInt(); } + watcher->deleteLater(); }); }