From 71c722c4a891528632301c88f8e0004d4c67cdc6 Mon Sep 17 00:00:00 2001 From: Mikolaj Boc Date: Wed, 30 Nov 2022 12:17:26 +0100 Subject: [PATCH] Fix the canvas element replacement for screen The deprecated path in QScreen still allows to provide a canvas as the screen element. The order of parameters in replaceChild call was wrong there, though. Change-Id: Id499967e3c9cdc1652e2dc251e352b9564c99f70 Reviewed-by: Lorn Potter --- src/plugins/platforms/wasm/qwasmscreen.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/platforms/wasm/qwasmscreen.cpp b/src/plugins/platforms/wasm/qwasmscreen.cpp index 578afb75cf..0e7d3e10a7 100644 --- a/src/plugins/platforms/wasm/qwasmscreen.cpp +++ b/src/plugins/platforms/wasm/qwasmscreen.cpp @@ -40,7 +40,7 @@ QWasmScreen::QWasmScreen(const emscripten::val &containerOrCanvas) qWarning() << "Support for canvas elements as an element backing screen is deprecated. The " "canvas provided for the screen will be transformed into a div."; auto container = document.call("createElement", emscripten::val("div")); - m_container["parentNode"].call("replaceChild", m_container, container); + m_container["parentNode"].call("replaceChild", container, m_container); m_container = container; } auto shadowOptions = emscripten::val::object();