whytofly
/
qt6-bb10
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Rename the replace() function's value to newValue to reflect its role 

Found in API-review

Pick-to: 6.7
Change-Id: Ib047c79d977ad6870c1e426cd1add994a3634df4
Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
Reviewed-by: Marc Mutz <marc.mutz@qt.io>
bb10
Juha Vuolle 2024-01-10 14:23:49 +02:00
parent f0db080880
commit 723ab99b1a
2 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/network/access/qhttpheaders.cpp
View File

@ -869,7 +869,7 @@ bool QHttpHeaders::insert(qsizetype i, WellKnownHeader name, QAnyStringView valu
}
/*!
Replaces the header entry at index \a i, with \a name and \a value.
Replaces the header entry at index \a i, with \a name and \a newValue.
The index must be valid (see \l size()). Returns whether the replace
succeeded.
@ -877,28 +877,28 @@ bool QHttpHeaders::insert(qsizetype i, WellKnownHeader name, QAnyStringView valu
replace(qsizetype, QHttpHeaders::WellKnownHeader, QAnyStringView), size()
\sa {Allowed field name and value characters}
*/
bool QHttpHeaders::replace(qsizetype i, QAnyStringView name, QAnyStringView value)
bool QHttpHeaders::replace(qsizetype i, QAnyStringView name, QAnyStringView newValue)
{
d->verify(i);
if (!isValidHttpHeaderNameField(name) || !isValidHttpHeaderValueField(value))
if (!isValidHttpHeaderNameField(name) || !isValidHttpHeaderValueField(newValue))
return false;
d.detach();
d->headers.replace(i, {normalizedName(name), normalizedValue(value)});
d->headers.replace(i, {normalizedName(name), normalizedValue(newValue)});
return true;
}
/*!
\overload replace(qsizetype, QAnyStringView, QAnyStringView)
*/
bool QHttpHeaders::replace(qsizetype i, WellKnownHeader name, QAnyStringView value)
bool QHttpHeaders::replace(qsizetype i, WellKnownHeader name, QAnyStringView newValue)
{
d->verify(i);
if (!isValidHttpHeaderValueField(value))
if (!isValidHttpHeaderValueField(newValue))
return false;
d.detach();
d->headers.replace(i, {headerNames[qToUnderlying(name)], normalizedValue(value)});
d->headers.replace(i, {headerNames[qToUnderlying(name)], normalizedValue(newValue)});
return true;
}

4
src/network/access/qhttpheaders.h
View File

@ -222,8 +222,8 @@ public:
Q_NETWORK_EXPORT bool insert(qsizetype i, QAnyStringView name, QAnyStringView value);
Q_NETWORK_EXPORT bool insert(qsizetype i, WellKnownHeader name, QAnyStringView value);
Q_NETWORK_EXPORT bool replace(qsizetype i, QAnyStringView name, QAnyStringView value);
Q_NETWORK_EXPORT bool replace(qsizetype i, WellKnownHeader name, QAnyStringView value);
Q_NETWORK_EXPORT bool replace(qsizetype i, QAnyStringView name, QAnyStringView newValue);
Q_NETWORK_EXPORT bool replace(qsizetype i, WellKnownHeader name, QAnyStringView newValue);
Q_NETWORK_EXPORT bool contains(QAnyStringView name) const;
Q_NETWORK_EXPORT bool contains(WellKnownHeader name) const;