Don't use a QTextStream to read lines from a file

QFile::readLine() can do the same at a fraction of the cost
of QTextStream.

Change-Id: I8c542756bcbd893dfa76d03e76e3ce0810aa2871
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
bb10
Lars Knoll 2020-04-28 12:57:55 +02:00
parent 8d89402435
commit 74306a02ce
1 changed files with 6 additions and 5 deletions

View File

@ -456,11 +456,12 @@ void QMimeBinaryProvider::loadMimeTypeList()
// So we have to parse the plain-text files called "types".
QFile file(m_directory + QStringLiteral("/types"));
if (file.open(QIODevice::ReadOnly)) {
QTextStream stream(&file);
stream.setCodec("ISO 8859-1");
QString line;
while (stream.readLineInto(&line))
m_mimetypeNames.insert(line);
while (!file.atEnd()) {
QByteArray line = file.readLine();
if (line.endsWith('\n'))
line.chop(1);
m_mimetypeNames.insert(QString::fromLatin1(line));
}
}
}
}