From 745c1f584d7fef16b9e3224d988afeb11043738e Mon Sep 17 00:00:00 2001 From: Eike Ziller Date: Tue, 1 Mar 2022 09:33:34 +0100 Subject: [PATCH] MIME providers: Make provider implementations final We do not derive from them, and making QMimeXMLProvider final avoids a warning about calling a virtual function from the constructor. Change-Id: I565c63eb555fabb3c98e7d284b54037b7a7194da Reviewed-by: David Faure --- src/corelib/mimetypes/qmimeprovider_p.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/corelib/mimetypes/qmimeprovider_p.h b/src/corelib/mimetypes/qmimeprovider_p.h index affc554698..00cf5fefbd 100644 --- a/src/corelib/mimetypes/qmimeprovider_p.h +++ b/src/corelib/mimetypes/qmimeprovider_p.h @@ -93,7 +93,7 @@ public: /* Parses the files 'mime.cache' and 'types' on demand */ -class QMimeBinaryProvider : public QMimeProviderBase +class QMimeBinaryProvider final : public QMimeProviderBase { public: QMimeBinaryProvider(QMimeDatabasePrivate *db, const QString &directory); @@ -138,7 +138,7 @@ private: /* Parses the raw XML files (slower) */ -class QMimeXMLProvider : public QMimeProviderBase +class QMimeXMLProvider final : public QMimeProviderBase { public: enum InternalDatabaseEnum { InternalDatabase };