From 766244e0336a5d5f142b4f83c950e0ebe42166ca Mon Sep 17 00:00:00 2001 From: Mate Barany Date: Mon, 17 Jun 2024 12:52:13 +0200 Subject: [PATCH] Use fully qualified signal arguments in QNetworkInformation MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Also in QNetworkInformationBackend. Task-number: QTBUG-125026 Change-Id: I3cc722a9e6db284a393bfddf0dfa4ebbcb6b4d07 Reviewed-by: MÃ¥rten Nordheim (cherry picked from commit d9d384b94fba0e15ed7f564309b0fbc48e5f4d7a) Reviewed-by: Qt Cherry-pick Bot --- src/network/kernel/qnetworkinformation.cpp | 2 +- src/network/kernel/qnetworkinformation.h | 4 ++-- src/network/kernel/qnetworkinformation_p.h | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/network/kernel/qnetworkinformation.cpp b/src/network/kernel/qnetworkinformation.cpp index 10d6b89e2c..5115372b20 100644 --- a/src/network/kernel/qnetworkinformation.cpp +++ b/src/network/kernel/qnetworkinformation.cpp @@ -328,7 +328,7 @@ QNetworkInformationBackend::~QNetworkInformationBackend() = default; */ /*! - \fn void QNetworkInformationBackend::reachabilityChanged() + \fn void QNetworkInformationBackend::reachabilityChanged(NetworkInformation::Reachability reachability) You should not emit this signal manually, call setReachability() instead which will emit this signal when the value changes. diff --git a/src/network/kernel/qnetworkinformation.h b/src/network/kernel/qnetworkinformation.h index 57a49f23c8..72e2b59550 100644 --- a/src/network/kernel/qnetworkinformation.h +++ b/src/network/kernel/qnetworkinformation.h @@ -76,9 +76,9 @@ public: static QNetworkInformation *instance(); Q_SIGNALS: - void reachabilityChanged(Reachability newReachability); + void reachabilityChanged(QNetworkInformation::Reachability newReachability); void isBehindCaptivePortalChanged(bool state); - void transportMediumChanged(TransportMedium current); + void transportMediumChanged(QNetworkInformation::TransportMedium current); void isMeteredChanged(bool isMetered); private: diff --git a/src/network/kernel/qnetworkinformation_p.h b/src/network/kernel/qnetworkinformation_p.h index 504955a6e1..76b2937ced 100644 --- a/src/network/kernel/qnetworkinformation_p.h +++ b/src/network/kernel/qnetworkinformation_p.h @@ -74,9 +74,9 @@ public: } Q_SIGNALS: - void reachabilityChanged(Reachability reachability); + void reachabilityChanged(QNetworkInformation::Reachability reachability); void behindCaptivePortalChanged(bool behindPortal); - void transportMediumChanged(TransportMedium medium); + void transportMediumChanged(QNetworkInformation::TransportMedium medium); void isMeteredChanged(bool isMetered); protected: