From 77a7b5c916e9100973dfe8063054df56ea7fd465 Mon Sep 17 00:00:00 2001 From: Giuseppe D'Angelo Date: Fri, 1 Sep 2017 18:49:14 +0200 Subject: [PATCH] tst_qitemmodel: do not pass illegal indices to QAbstractItemModel APIs That's undefined behavior, so don't test it. Change-Id: I468637ff1835f4f50859ac3d9876463221a3285a Reviewed-by: David Faure --- tests/auto/corelib/itemmodels/qitemmodel/tst_qitemmodel.cpp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/tests/auto/corelib/itemmodels/qitemmodel/tst_qitemmodel.cpp b/tests/auto/corelib/itemmodels/qitemmodel/tst_qitemmodel.cpp index 8ebb860edd..3d9446965e 100644 --- a/tests/auto/corelib/itemmodels/qitemmodel/tst_qitemmodel.cpp +++ b/tests/auto/corelib/itemmodels/qitemmodel/tst_qitemmodel.cpp @@ -533,9 +533,6 @@ void tst_QItemModel::data() // A valid index should have a valid qvariant data QVERIFY(currentModel->index(0,0).isValid()); - // shouldn't be able to set data on an invalid index - QCOMPARE(currentModel->setData(QModelIndex(), "foo", Qt::DisplayRole), false); - // General Purpose roles QVariant variant = currentModel->data(currentModel->index(0,0), Qt::ToolTipRole); if (variant.isValid()) { @@ -605,7 +602,6 @@ void tst_QItemModel::setData() QVERIFY(currentModel); QSignalSpy spy(currentModel, &QAbstractItemModel::dataChanged); QVERIFY(spy.isValid()); - QCOMPARE(currentModel->setData(QModelIndex(), QVariant()), false); QCOMPARE(spy.count(), 0); QFETCH(bool, isEmpty);