From 7876add8b13e166711dc42e458baab43d50999d2 Mon Sep 17 00:00:00 2001 From: Timur Pocheptsov Date: Fri, 29 Jul 2016 15:18:34 +0200 Subject: [PATCH] QSslDiffieHellmanParameters_dummy - remove Q_UNIMPLEMENTED As a part of SSL initialization (done by QNAM on the first HTTP get request, for example), 'dummy' Diffie/Hellman parameter's mem-functions constantly and unconditionally print 'Unimplemented code' even without user actually calling these unimplemented methods. This is not just annoying, (just realized I saw this 'Unimplemented code' many times today) this also breaks several our auto-tests (xmlpatterns/qquickimage for example) - the ones that expect output to be empty. Task-number: QTBUG-55003 Change-Id: I5e4822e9783de32aa4b00843a9916eafea3689c0 Reviewed-by: Richard J. Moore Reviewed-by: Frederik Gladhorn --- src/network/ssl/qssldiffiehellmanparameters_dummy.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/network/ssl/qssldiffiehellmanparameters_dummy.cpp b/src/network/ssl/qssldiffiehellmanparameters_dummy.cpp index 42222f3f38..220c017f4c 100644 --- a/src/network/ssl/qssldiffiehellmanparameters_dummy.cpp +++ b/src/network/ssl/qssldiffiehellmanparameters_dummy.cpp @@ -48,12 +48,10 @@ QT_BEGIN_NAMESPACE void QSslDiffieHellmanParametersPrivate::decodeDer(const QByteArray &) { - Q_UNIMPLEMENTED(); } void QSslDiffieHellmanParametersPrivate::decodePem(const QByteArray &) { - Q_UNIMPLEMENTED(); } QT_END_NAMESPACE