From 7dfa00e1ccef3ce9f29d54bde55411da9f71bcc5 Mon Sep 17 00:00:00 2001 From: Alexandru Croitor Date: Thu, 26 Mar 2020 16:27:57 +0100 Subject: [PATCH] Coin: Fix incorrect target OS values used in instructions The friendly named values should be used rather than the all caps names. Change-Id: I44dbe8c25d405424c5cd2c9527b6e884511ac269 Reviewed-by: Toni Saario Reviewed-by: Simon Hausmann --- coin/instructions/prepare_building_env.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/coin/instructions/prepare_building_env.yaml b/coin/instructions/prepare_building_env.yaml index f862459ba3..d9a22c76b2 100644 --- a/coin/instructions/prepare_building_env.yaml +++ b/coin/instructions/prepare_building_env.yaml @@ -91,21 +91,21 @@ instructions: enable_if: condition: property property: target.os - in_values: ["WINRT", "WINPHONE", "WINCE"] + in_values: ["WinRT", "WinPhone", "WinCE"] - type: EnvironmentVariable variableName: WINDOWS_SDK_VERSION variableValue: "10.0.14393.0" enable_if: condition: property property: target.os - equals_value: WINRT + equals_value: "WinRT" - type: EnvironmentVariable variableName: WINDOWS_SDK_VERSION variableValue: "" disable_if: condition: property property: host.os - equals_value: WINRT # TODO set windows sdk version for desktop windows as well + equals_value: "WinRT" # TODO set windows sdk version for desktop windows as well # MSVC is installed in somehow arbitrary places. To reduce amount of combinations we need to make a variable.