From 7e6f44f38ba6d9b430e0dbaecaad31f3f9e0619b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Storsj=C3=B6?= Date: Fri, 10 May 2024 10:41:01 +0300 Subject: [PATCH] QDnsLookup: Fix -Wc++11-narrowing error on 32 bit Windows MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This fixes errors like this, with Clang, for 32 bit Windows targets: src/network/kernel/qdnslookup_win.cpp:99:54: error: non-constant-expression cannot be narrowed from type 'DWORD' (aka 'unsigned long') to 'qsizetype' (aka 'int') in initializer list [-Wc++11-narrowing] 99 | if (!self->sendDnsOverTls(reply, { query.data(), dnsBufferSize }, replyBuffer)) | ^~~~~~~~~~~~~ src/network/kernel/qdnslookup_win.cpp:99:54: note: insert an explicit cast to silence this issue 99 | if (!self->sendDnsOverTls(reply, { query.data(), dnsBufferSize }, replyBuffer)) | ^~~~~~~~~~~~~ | static_cast( ) Change-Id: If313e0910006f7556087f272123a0cfe1239f818 Reviewed-by: Thiago Macieira Reviewed-by: Mårten Nordheim --- src/network/kernel/qdnslookup_win.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/network/kernel/qdnslookup_win.cpp b/src/network/kernel/qdnslookup_win.cpp index 92dd95ab53..1b07776db9 100644 --- a/src/network/kernel/qdnslookup_win.cpp +++ b/src/network/kernel/qdnslookup_win.cpp @@ -96,7 +96,7 @@ static DNS_STATUS sendAlternate(QDnsLookupRunnable *self, QDnsLookupReply *reply dnsBuffer->MessageHead.AuthenticatedData = true; QDnsLookupRunnable::ReplyBuffer replyBuffer; - if (!self->sendDnsOverTls(reply, { query.data(), dnsBufferSize }, replyBuffer)) + if (!self->sendDnsOverTls(reply, { query.data(), qsizetype(dnsBufferSize) }, replyBuffer)) return DNS_STATUS(-1); // error set in reply // interpret the RCODE in the reply