From 8a67b0c20cf16bf095484c8d2aab459496f18512 Mon Sep 17 00:00:00 2001 From: Ahmad Samir Date: Wed, 31 May 2023 18:56:01 +0300 Subject: [PATCH] Add missing #includes This is needed by static analysis tools (which compile each header on its own, IIUC), e.g. clang-tidy: src/widgets/itemviews/qtableview_p.h:99:22: error: unknown type name 'QTableView' [clang-diagnostic-error]. Q_DECLARE_PUBLIC(QTableView) ^ Change-Id: I84a1221469e9a78f243cc892ef7c60da9b515718 Reviewed-by: Richard Moe Gustavsen --- src/corelib/itemmodels/qabstractproxymodel_p.h | 1 + src/corelib/itemmodels/qitemselectionmodel_p.h | 1 + src/widgets/itemviews/qabstractitemview_p.h | 1 + src/widgets/itemviews/qheaderview_p.h | 1 + src/widgets/itemviews/qlistview_p.h | 1 + src/widgets/itemviews/qtableview_p.h | 3 +++ src/widgets/itemviews/qwidgetitemdata_p.h | 1 + 7 files changed, 9 insertions(+) diff --git a/src/corelib/itemmodels/qabstractproxymodel_p.h b/src/corelib/itemmodels/qabstractproxymodel_p.h index 678ec4804f..70bc482ffd 100644 --- a/src/corelib/itemmodels/qabstractproxymodel_p.h +++ b/src/corelib/itemmodels/qabstractproxymodel_p.h @@ -16,6 +16,7 @@ // // +#include "qabstractproxymodel.h" #include "private/qabstractitemmodel_p.h" #include "private/qproperty_p.h" diff --git a/src/corelib/itemmodels/qitemselectionmodel_p.h b/src/corelib/itemmodels/qitemselectionmodel_p.h index f63526e8ae..0f5fd30b28 100644 --- a/src/corelib/itemmodels/qitemselectionmodel_p.h +++ b/src/corelib/itemmodels/qitemselectionmodel_p.h @@ -15,6 +15,7 @@ // We mean it. // +#include "qitemselectionmodel.h" #include "private/qobject_p.h" #include "private/qproperty_p.h" diff --git a/src/widgets/itemviews/qabstractitemview_p.h b/src/widgets/itemviews/qabstractitemview_p.h index 5475db2971..c3cc80e139 100644 --- a/src/widgets/itemviews/qabstractitemview_p.h +++ b/src/widgets/itemviews/qabstractitemview_p.h @@ -16,6 +16,7 @@ // #include +#include "qabstractitemview.h" #include "private/qabstractscrollarea_p.h" #include "private/qabstractitemmodel_p.h" #include "QtWidgets/qapplication.h" diff --git a/src/widgets/itemviews/qheaderview_p.h b/src/widgets/itemviews/qheaderview_p.h index c599aeff8d..b215e06599 100644 --- a/src/widgets/itemviews/qheaderview_p.h +++ b/src/widgets/itemviews/qheaderview_p.h @@ -16,6 +16,7 @@ // #include +#include "qheaderview.h" #include "private/qabstractitemview_p.h" #include "QtCore/qbitarray.h" diff --git a/src/widgets/itemviews/qlistview_p.h b/src/widgets/itemviews/qlistview_p.h index de928bbb28..40dabf5656 100644 --- a/src/widgets/itemviews/qlistview_p.h +++ b/src/widgets/itemviews/qlistview_p.h @@ -16,6 +16,7 @@ // #include +#include "qlistview.h" #include "private/qabstractitemview_p.h" #include "qbitarray.h" #include "qbsptree_p.h" diff --git a/src/widgets/itemviews/qtableview_p.h b/src/widgets/itemviews/qtableview_p.h index 582330c7b5..614ec03408 100644 --- a/src/widgets/itemviews/qtableview_p.h +++ b/src/widgets/itemviews/qtableview_p.h @@ -16,6 +16,9 @@ // #include +#include "qtableview.h" +#include "qheaderview.h" + #include #include #include diff --git a/src/widgets/itemviews/qwidgetitemdata_p.h b/src/widgets/itemviews/qwidgetitemdata_p.h index 0fbaae34bd..f8c2d47085 100644 --- a/src/widgets/itemviews/qwidgetitemdata_p.h +++ b/src/widgets/itemviews/qwidgetitemdata_p.h @@ -6,6 +6,7 @@ #include #include +#include // // W A R N I N G