From 8b882f42e80f4b98e8fefcbae30a85382e67ef4a Mon Sep 17 00:00:00 2001 From: Thiago Macieira Date: Tue, 22 Jun 2021 08:28:18 -0700 Subject: [PATCH] SCTP: fix qsizetype miss MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Found by clang 12: qsctpsocket.cpp:172:56: error: result of comparison of constant 9223372036854775782 with expression of type 'int' is always true [-Werror,-Wtautological-constant-out-of-range-compare] Q_ASSERT((datagramSize + int(bytesToRead)) < MaxByteArraySize); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~ Change-Id: I7246c3e7bb894e0d9521fffd168af11764956d8f Reviewed-by: Mårten Nordheim --- src/network/socket/qsctpsocket.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/network/socket/qsctpsocket.cpp b/src/network/socket/qsctpsocket.cpp index fe76f64c42..092901f8f7 100644 --- a/src/network/socket/qsctpsocket.cpp +++ b/src/network/socket/qsctpsocket.cpp @@ -156,7 +156,7 @@ bool QSctpSocketPrivate::canReadNotification() const int savedCurrentChannel = currentReadChannel; bool currentChannelRead = false; do { - int datagramSize = incomingDatagram.size(); + qsizetype datagramSize = incomingDatagram.size(); QIpPacketHeader header; do { @@ -169,7 +169,7 @@ bool QSctpSocketPrivate::canReadNotification() bytesToRead = 4096; } - Q_ASSERT((datagramSize + int(bytesToRead)) < MaxByteArraySize); + Q_ASSERT((datagramSize + qsizetype(bytesToRead)) < MaxByteArraySize); incomingDatagram.resize(datagramSize + int(bytesToRead)); #if defined (QSCTPSOCKET_DEBUG)