From 8d549c33657974dcabf170c01225701ca0277ac2 Mon Sep 17 00:00:00 2001 From: Ahmad Samir Date: Wed, 17 Apr 2024 19:11:02 +0200 Subject: [PATCH] QTemporaryFileEngine: minor optimization The original code updated d->fileEntry twice in a row: it assigned to it directly, then called QFSFileEngine::setFileName() which assigned to d->fileEntry again. Now only one QFileSystemEntry is constructed. Change-Id: I3cdc131b97455c14e5b032fbdecdae0eaa32925f Reviewed-by: Oswald Buddenhagen Reviewed-by: Thiago Macieira --- src/corelib/io/qtemporaryfile_p.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/corelib/io/qtemporaryfile_p.h b/src/corelib/io/qtemporaryfile_p.h index 8815069daa..d160afe41e 100644 --- a/src/corelib/io/qtemporaryfile_p.h +++ b/src/corelib/io/qtemporaryfile_p.h @@ -88,8 +88,7 @@ public: if (filePathIsTemplate) { d->fileEntry.clear(); } else { - d->fileEntry = QFileSystemEntry(file); - QFSFileEngine::setFileName(file); + QFSFileEngine::setFileEntry(QFileSystemEntry(file)); } } ~QTemporaryFileEngine();