From 8ef89c1c01c79de404d6bb0abe9072fb1438e2b1 Mon Sep 17 00:00:00 2001 From: Vladimir Belyavsky Date: Sat, 20 Apr 2024 12:06:19 +0300 Subject: [PATCH] Silence Clazy's warning in QCborContainerPrivate::insertAt() Use more suitable QList::insert() overload and silence Clazy's "mixing iterators" warning. The warning is non-sense for this particular place, but it won't harm to avoid C-style cast and iterators arithmetics there. Change-Id: Ibfc8c8003473de3b7d9b67965e25a4cdb6a9f043 Reviewed-by: Thiago Macieira --- src/corelib/serialization/qcborvalue_p.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/corelib/serialization/qcborvalue_p.h b/src/corelib/serialization/qcborvalue_p.h index cbfc6b17a5..33eb912a6d 100644 --- a/src/corelib/serialization/qcborvalue_p.h +++ b/src/corelib/serialization/qcborvalue_p.h @@ -195,7 +195,7 @@ public: } void insertAt(qsizetype idx, const QCborValue &value, ContainerDisposition disp = CopyContainer) { - replaceAt_internal(*elements.insert(elements.begin() + int(idx), {}), value, disp); + replaceAt_internal(*elements.insert(idx, {}), value, disp); } void append(QtCbor::Undefined)