From 971bdc90e99db2d6d93d802d389be027189746d2 Mon Sep 17 00:00:00 2001 From: Gabriel de Dietrich Date: Thu, 27 Jun 2013 20:01:05 +0200 Subject: [PATCH] QIcon: Avoid fetching twice the same pixmap Looks like something went through the reviewer's eyes. This commit amends 6ec9b34cbb5fa6b1214cc6551002f46f732ba72f. Change-Id: I59a05361b1cbdf4e5177821d958766ffe3218f16 Reviewed-by: Jake Petroules Reviewed-by: Jens Bache-Wiig --- src/gui/image/qicon.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gui/image/qicon.cpp b/src/gui/image/qicon.cpp index 45eda78397..aef7324171 100644 --- a/src/gui/image/qicon.cpp +++ b/src/gui/image/qicon.cpp @@ -181,7 +181,7 @@ void QPixmapIconEngine::paint(QPainter *painter, const QRect &rect, QIcon::Mode { QSize pixmapSize = rect.size() * qt_effective_device_pixel_ratio(0); QPixmap px = pixmap(pixmapSize, mode, state); - painter->drawPixmap(rect, pixmap(pixmapSize, mode, state)); + painter->drawPixmap(rect, px); } static inline int area(const QSize &s) { return s.width() * s.height(); }