From 9aaaa8427d5d9e9141e0b1b02595a6b96f37cb0c Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Mon, 6 Feb 2017 22:35:30 +0100 Subject: [PATCH] QCollatorSortKey: use QExplicitlySharedDataPointer as pImpl The key is immutable except for assignment and swap, so don't run the risk of auto-detaching and use the explicit-detach version of QSharedDataPointer. Change-Id: Ib2cfe5981e6dfe375d6208289ff58247ef9d4870 Reviewed-by: Lars Knoll --- src/corelib/tools/qcollator.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/corelib/tools/qcollator.h b/src/corelib/tools/qcollator.h index 5ff74fd69a..d81c7c85e3 100644 --- a/src/corelib/tools/qcollator.h +++ b/src/corelib/tools/qcollator.h @@ -69,7 +69,7 @@ public: protected: QCollatorSortKey(QCollatorSortKeyPrivate*); - QSharedDataPointer d; + QExplicitlySharedDataPointer d; private: QCollatorSortKey();